feat: Add EKS handlers #1254
Open
feat: Add EKS handlers #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
cdbbed1 to
c06c78a
Compare
jimmidyson
force-pushed
the
jimmi/add-eks-external-api
branch
from
d182347 to
5757828
Compare
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
c06c78a to
b3e2485
Compare
jimmidyson
force-pushed
the
jimmi/add-eks-external-api
branch
from
5757828 to
2dd9539
Compare
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
b3e2485 to
3de1474
Compare
dkoshkin
reviewed
Aug 13, 2025
| @@ -124,6 +125,10 @@ func main() { | |||
| // It allows to specify configuration under a single variable. | |||
| genericMetaHandlers := generic.New() | |||
|
|
|||
| // eksMetaHandlers combines all EKS patch and variable handlers under a single handler. | |||
| // It allows to specify configuration under a single variable. | |||
| eksMetaHandlers := eks.New(globalOptions) | |||
There was a problem hiding this comment.
nit: can we move this above the genericMetaHandlers to group all provider handlers?
| @@ -173,6 +178,7 @@ func main() { | |||
| allHandlers = append(allHandlers, dockerMetaHandlers.AllHandlers(mgr)...) | |||
| allHandlers = append(allHandlers, nutanixMetaHandlers.AllHandlers(mgr)...) | |||
| allHandlers = append(allHandlers, genericMetaHandlers.AllHandlers(mgr)...) | |||
| allHandlers = append(allHandlers, eksMetaHandlers.AllHandlers(mgr)...) | |||
There was a problem hiding this comment.
nit: also this next to the other provider handlers
| @@ -187,6 +192,13 @@ func (s GenericClusterConfig) VariableSchema() clusterv1.VariableSchema { //noli | |||
|
|
|||
| // GenericClusterConfigSpec defines the desired state of GenericClusterConfig. | |||
| type GenericClusterConfigSpec struct { | |||
| GenericClusterConfigResource `json:",inline"` | |||
There was a problem hiding this comment.
Can you please clarify why this is changing
| patchHandlers = append(patchHandlers, metaMutators()...) | ||
|
|
||
| return mutation.NewMetaGeneratePatchesHandler( | ||
| "eksClusterV1ConfigPatch", |
There was a problem hiding this comment.
Should we keep the version consistent across all providers? There is only a single v3 folder with all other handlers, I think its going to get very complicated trying to maintain different versions.
Suggested change
| "eksClusterV1ConfigPatch", | |
| "eksClusterV4ConfigPatch", |
jimmidyson
force-pushed
the
jimmi/add-eks-external-api
branch
from
2dd9539 to
279c4bf
Compare
Reusing as much as possible of the AWS handlers, with slight tweaks.
jimmidyson
force-pushed
the
jimmi/eks-handlers
branch
from
f754dfa to
c5dd8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing as much as possible of the AWS handlers, with slight tweaks.
What problem does this PR solve?:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer:
Requires #1253.